cloud-fan commented on code in PR #41298:
URL: https://github.com/apache/spark/pull/41298#discussion_r1205190736
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala:
##########
@@ -2044,12 +2044,14 @@ case class MonthsBetween(
case class ParseToDate(
left: Expression,
format: Option[Expression],
- timeZoneId: Option[String] = None)
+ timeZoneId: Option[String] = None,
+ ansiEnabled: Boolean = SQLConf.get.ansiEnabled)
extends RuntimeReplaceable with ImplicitCastInputTypes with
TimeZoneAwareExpression {
override lazy val replacement: Expression = format.map { f =>
- Cast(GetTimestamp(left, f, TimestampType, timeZoneId), DateType,
timeZoneId)
- }.getOrElse(Cast(left, DateType, timeZoneId)) // backwards compatibility
+ Cast(GetTimestamp(left, f, TimestampType, timeZoneId, ansiEnabled),
DateType, timeZoneId)
Review Comment:
the Cast here still doesn't have the evalMod passed... But it's a good catch
that we should pass ansiEnabled to GetTimestamp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
