HyukjinKwon commented on code in PR #41211:
URL: https://github.com/apache/spark/pull/41211#discussion_r1206226800
##########
python/pyspark/pandas/frame.py:
##########
@@ -1889,6 +1889,8 @@ def items(self) -> Iterator[Tuple[Name, "Series"]]:
... print('label:', label)
... print('content:', content.to_string())
...
+ ... # doctest: +SKIP
+ # TODO(SPARK-43480): Enable SeriesTests.test_iteritems for pandas
2.0.0.
Review Comment:
It shouldn't be here. This TODO comment will be shown in docstring
##########
python/pyspark/pandas/tests/indexes/test_datetime.py:
##########
@@ -81,8 +86,6 @@ def test_properties(self):
self.assert_eq(psidx.minute, pidx.minute)
self.assert_eq(psidx.second, pidx.second)
self.assert_eq(psidx.microsecond, pidx.microsecond)
- self.assert_eq(psidx.week, pidx.week)
- self.assert_eq(psidx.weekofyear, pidx.weekofyear)
Review Comment:
why did we remove?
##########
python/pyspark/pandas/tests/test_categorical.py:
##########
@@ -371,10 +388,14 @@ def test_groupby_apply_without_shortcut(self):
def identity(df) -> ps.DataFrame[zip(psdf.columns, psdf.dtypes)]:
return df
- self.assert_eq(
- psdf.groupby("a").apply(identity).sort_values(["a",
"b"]).reset_index(drop=True),
- pdf.groupby("a").apply(identity).sort_values(["a",
"b"]).reset_index(drop=True),
- )
+ if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
Review Comment:
ditto
##########
python/pyspark/pandas/tests/test_dataframe.py:
##########
@@ -4026,10 +4030,19 @@ def test_reindex(self):
psdf.reindex(["A", "B", "C"], columns=["numbers", "2",
"3"]).sort_index(),
)
- self.assert_eq(
- pdf.reindex(["A", "B", "C"], index=["numbers", "2",
"3"]).sort_index(),
- psdf.reindex(["A", "B", "C"], index=["numbers", "2",
"3"]).sort_index(),
- )
+ # TODO(SPARK-43271): Match behavior with DataFrame.reindex with
specifying `index`.
+ if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
Review Comment:
ditto
##########
python/pyspark/pandas/tests/indexes/test_datetime.py:
##########
@@ -101,6 +104,28 @@ def test_properties(self):
self.assert_eq(psidx.day_of_year, pidx.day_of_year)
self.assert_eq(psidx.day_of_week, pidx.day_of_week)
+ if LooseVersion(pd.__version__) >= LooseVersion("2.0.0"):
Review Comment:
why do we need this now? I thought you're going to address the different
results in a separate tickets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
