MaxGekk commented on code in PR #41319:
URL: https://github.com/apache/spark/pull/41319#discussion_r1207164442
##########
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/numeric.sql:
##########
@@ -884,6 +884,12 @@ SELECT '' AS to_char_10, to_char(val,
'S0999999999999999.999999999999999'), val
-- SELECT '' AS to_char_35, to_char('100'::numeric, 'f"ool\"999');
-- SELECT '' AS to_char_36, to_char('100'::numeric, 'f"ool\\"999');
+-- [SPARK-43815] Add support for additional SQL functions
Review Comment:
Please, change the ticket title. Now it is too much generic. The PR's title
looks nice for that.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -531,6 +531,7 @@ object FunctionRegistry {
expression[ToNumber]("to_number"),
expression[TryToNumber]("try_to_number"),
expression[ToCharacter]("to_char"),
+ expression[ToCharacter]("to_varchar", setAlias = true, Some("3.4.0")),
Review Comment:
Change the version to 3.5.0. We are not going to backport this alias back to
already released 3.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
