MaxGekk commented on code in PR #41203: URL: https://github.com/apache/spark/pull/41203#discussion_r1207835519
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala: ########## @@ -265,12 +271,16 @@ case class HllUnionAgg( override protected def withNewChildrenInternal(newLeft: Expression, newRight: Expression): HllUnionAgg = copy(left = newLeft, right = newRight) + // Overrides for ExpectsInputTypes + + override def inputTypes: Seq[AbstractDataType] = Seq(BinaryType, BooleanType) + + override def inputIsFoldable: Seq[Option[Boolean]] = Seq(None, Some(true)) Review Comment: `None` means that you don't care of it is foldable or not, correct? You just require to be foldable for the second parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
