HyukjinKwon commented on code in PR #41343:
URL: https://github.com/apache/spark/pull/41343#discussion_r1208714143
##########
python/pyspark/sql/protobuf/functions.py:
##########
@@ -232,6 +274,12 @@ def to_protobuf(
return Column(jc)
+def _read_descriptor_set_file(filePath: str) -> bytes:
+ # TODO: Throw structured errors like "PROTOBUF_DESCRIPTOR_FILE_NOT_FOUND"
etc.
Review Comment:
and should file TODO'ed JIRA such as `TODO(SPARK-XXXXX)`. It's a bit trouble
some to file for every todo but we found that some of todos are just left out,
forgotten, and nobody remembers what it was :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
