bersprockets commented on PR #41368:
URL: https://github.com/apache/spark/pull/41368#issuecomment-1567622960
I don't know all the details about prefixes (how many parts there can be,
etc.), but given that, this looks fine to me.
Related to this area, but not caused by this PR, is the oddity of seeing
auto-generated prefixes, which I assume are internal to Spark, in the list of
suggestions:
```
with v1 as (
select * from values (1, 2) as (c1, c2)
),
v2 as (
select * from values (2, 3) as (c1, c2)
)
select v1.b
from (
select coalesce(v1.c1, v2.c1) as c1, v1.c1 as v1_c1, v1.c2 as v1_c2, v2.c1
as v2_c1, v2.c2 as v2_c2
from v1
full outer join v2
on v1.c1 = v2.c1
);
[UNRESOLVED_COLUMN.WITH_SUGGESTION] A column or function parameter with name
`v1`.`b` cannot be resolved. Did you mean one of the following?
[`__auto_generated_subquery_name`.`c1`,
`__auto_generated_subquery_name`.`v1_c1`,
`__auto_generated_subquery_name`.`v1_c2`,
`__auto_generated_subquery_name`.`v2_c1`,
`__auto_generated_subquery_name`.`v2_c2`].; line 7 pos 7;
```
Someone might follow the suggestion and use
`__auto_generated_subquery_name.c1` in their query, only to have a later update
to Spark change the internal name. Not sure if that's in scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
