amaliujia commented on code in PR #41311:
URL: https://github.com/apache/spark/pull/41311#discussion_r1210745031


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -639,4 +639,12 @@ abstract class Catalog {
    * @since 3.5.0
    */
   def listCatalogs(): Dataset[CatalogMetadata]
+
+  /**
+   * Returns a list of catalogs which name match the specify pattern and 
available in this
+   * session.
+   *
+   * @since 3.5.0
+   */
+  def listCatalogs(pattern: String): Dataset[CatalogMetadata]

Review Comment:
   @zhengruifeng in fact, what kind of binary compatibility that we are 
discussing?
   
   The suggested change is still compatibility with existing code? The only way 
I can think that will break is through reflection (so tried to load 
`listCatalogs()` but there is no such signature). Is this the binary 
compatibility referred here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to