chaoqin-li1123 commented on code in PR #41099:
URL: https://github.com/apache/spark/pull/41099#discussion_r1211107696
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -865,10 +1076,14 @@ class RocksDBSuite extends SparkFunSuite {
}
}
+ private def sqlConf = SQLConf.get
+
+ private def dbConf = RocksDBConf(StateStoreConf(sqlConf))
Review Comment:
This should be fine because it creates a new RocksDBConf every, changed the
above code to clone the sqlConf
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -865,10 +1076,14 @@ class RocksDBSuite extends SparkFunSuite {
}
}
+ private def sqlConf = SQLConf.get
+
+ private def dbConf = RocksDBConf(StateStoreConf(sqlConf))
Review Comment:
This should be fine because it creates a new RocksDBConf every time, changed
the above code to clone the sqlConf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
