cloud-fan commented on code in PR #41052:
URL: https://github.com/apache/spark/pull/41052#discussion_r1211190855
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -117,6 +119,10 @@ private[sql] class AvroDeserializer(
val incompatibleMsg = errorPrefix +
s"schema is incompatible (avroType = $avroType, sqlType =
${catalystType.sql})"
+ val realDataType = SchemaConverters.toSqlType(avroType).dataType
+ val confKey = SQLConf.LEGACY_AVRO_ALLOW_INCOMPATIBLE_SCHEMA
+ val preventReadingIncorrectType = !SQLConf.get.getConf(confKey)
+
(avroType.getType, catalystType) match {
Review Comment:
My preference of the code structure is something like this
```
val logicalDataType = SchemaConverters.toSqlType(avroType).dataType
avroType.getType match {
case INT =>
(logicalDataType, catalystType) match {
case (IntegerType, IntegerType) => ...
// allowed for backward compatibility as Avro didn't have logicla date
type at the beginning
case (IntegerType, DateType) => ...
case (DateType, DateType) => ...
case (YearMonthIntervalType, YearMonthIntervalType) => ...
case _ => fail
}
case ...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
