Hisoka-X commented on code in PR #40953:
URL: https://github.com/apache/spark/pull/40953#discussion_r1212524603
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala:
##########
@@ -93,13 +93,15 @@ private object PostgresDialect extends JdbcDialect with
SQLConfHelper {
case "numeric" | "decimal" if precision > 0 =>
Some(DecimalType.bounded(precision, scale))
case "numeric" | "decimal" =>
// SPARK-26538: handle numeric without explicit precision and scale.
- Some(DecimalType. SYSTEM_DEFAULT)
+ Some(DecimalType.SYSTEM_DEFAULT)
case "money" =>
// money[] type seems to be broken and difficult to handle.
// So this method returns None for now.
// See SPARK-34333 and https://github.com/pgjdbc/pgjdbc/issues/1405
None
- case _ => None
+ case _ =>
+ // SPARK-43267: handle unknown types in array as string, because there
are user-defined types
+ Some(StringType)
Review Comment:
Thanks for remind, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
