Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6322#discussion_r30860898
  
    --- Diff: python/pyspark/ml/evaluation.py ---
    @@ -15,13 +15,52 @@
     # limitations under the License.
     #
     
    +from abc import abstractmethod, ABCMeta
    +
     from pyspark.ml.wrapper import JavaEvaluator
     from pyspark.ml.param import Param, Params
     from pyspark.ml.param.shared import HasLabelCol, HasRawPredictionCol
     from pyspark.ml.util import keyword_only
     from pyspark.mllib.common import inherit_doc
     
    -__all__ = ['BinaryClassificationEvaluator']
    +__all__ = ['Evaluator', 'BinaryClassificationEvaluator']
    +
    +
    +class Evaluator(Params):
    --- End diff --
    
    Add ```@inherit_doc```?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to