[GitHub] [spark] MaxGekk commented on a diff in pull request #41424: [SPARK-43913][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[2426-2432]

[via GitHub]

MaxGekk commented on code in PR #41424:
URL: https://github.com/apache/spark/pull/41424#discussion_r1215752166


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -624,8 +626,8 @@ trait CheckAnalysis extends PredicateHelper with 
LookupCatalog with QueryErrorsB
 
             if (badReferences.nonEmpty) {
               create.failAnalysis(
-                errorClass = "_LEGACY_ERROR_TEMP_2431",
-                messageParameters = Map("cols" -> badReferences.mkString(", 
")))
+                errorClass = 
"UNSUPPORTED_FEATURE.PARTITION_WITH_NESTED_COLUMN_IS_UNSUPPORTED",
+                messageParameters = Map("cols" -> badReferences.map(r => 
s"`$r`").mkString(", ")))

Review Comment:
   Please, use `toSQLId` for quoting ids.



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1834,6 +1849,11 @@
     ],
     "sqlState" : "42K05"
   },
+  "RESOLVED_ATTRIBUTE_MISSING_FROM_INPUT" : {
+    "message" : [
+      "<msg>"

Review Comment:
   Consider to replace the messages 
https://github.com/apache/spark/blob/898ad77900d887ac64800a616bd382def816eea6/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala#L646-L660
   by a sub-class of `UNRESOLVED_COLUMN` or add new ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org