gengliangwang commented on code in PR #41191: URL: https://github.com/apache/spark/pull/41191#discussion_r1217103535
########## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ########## @@ -158,30 +158,37 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager) // For CREATE TABLE [AS SELECT], we should use the v1 command if the catalog is resolved to the // session catalog and the table provider is not v2. - case c @ CreateTable(ResolvedV1Identifier(ident), _, _, _, _) => + case c @ CreateTable(ResolvedV1Identifier(ident), _, _, u: UnresolvedTableSpec, _, Review Comment: Nit: shall we have a single rule for resolving the table spec? This rule is for resolving session catalogs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org