allisonwang-db commented on code in PR #41316: URL: https://github.com/apache/spark/pull/41316#discussion_r1217498437
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/pythonLogicalOperators.scala: ########## @@ -171,6 +186,18 @@ case class ArrowEvalPython( copy(child = newChild) } +/** + * A logical plan that evaluates a [[PythonUDTF]]. + */ +case class BatchEvalPythonUDTF( Review Comment: Yes batch eval is the baseline impl and we should enable arrow by default for UDTFs. I am going to work on it next given we are supporting complex types for arrow based UDFs. Created a follow-up ticket: https://issues.apache.org/jira/browse/SPARK-43964. > It's not worthwhile refactoring the batch eval code path @HyukjinKwon that's a good point. Should I consider duplicating the code instead of refactoring it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org