RyanBerti commented on code in PR #41203:
URL: https://github.com/apache/spark/pull/41203#discussion_r1218729428
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -1876,6 +1876,49 @@ class DataFrameAggregateSuite extends QueryTest
checkAnswer(res, Nil)
}
assert(error7.toString contains "UnsupportedOperationException")
+
+ // validate specific args require foldable = true
+ val error8 = intercept[AnalysisException] {
+ val res = sql(
+ """with cte as (
+ |select * from values
+ | (1, 12)
+ | as tab(col, logk)
+ |)
+ |select hll_sketch_agg(col, logk) from cte
+ |""".stripMargin
+ )
+ checkAnswer(res, Nil)
+ }
+ assert(error8.toString contains "UNEXPECTED_INPUT_FOLDABLE_VALUE")
Review Comment:
I'm seeing various other negative test cases in this suite that use assert,
and no examples of checkError. Is there a good example of checkError I could
reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
