zhengruifeng commented on code in PR #41444: URL: https://github.com/apache/spark/pull/41444#discussion_r1218740413
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ########## @@ -1658,6 +1659,24 @@ class SparkConnectPlanner(val session: SparkSession) { Some( CatalystDataToProtobuf(children.head, messageClassName, binaryFileDescSetOpt, options)) + case "percentile_cont" if Seq(2, 3).contains(fun.getArgumentsCount) => Review Comment: do we plan to support `percentile_cont` and `percentile_disc`? they are not [in the list](https://issues.apache.org/jira/browse/SPARK-43907) if we support them, shall we add them to `FunctionRegistry ` ? @HyukjinKwon @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org