[GitHub] [spark] turboFei commented on a diff in pull request #41201: [SPARK-43540][K8S][CORE] Add working directory into classpath on the driver in K8S cluster mode

[via GitHub]

turboFei commented on code in PR #41201:
URL: https://github.com/apache/spark/pull/41201#discussion_r1218854527


##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh:
##########
@@ -75,6 +75,9 @@ elif ! [ -z ${SPARK_HOME+x} ]; then
   SPARK_CLASSPATH="$SPARK_HOME/conf:$SPARK_CLASSPATH";
 fi
 
+# SPARK-43540: add current working directory into executor classpath
+SPARK_CLASSPATH="$PWD:$SPARK_CLASSPATH"

Review Comment:
   sorry for the late reply, I checked the code.
   
   For driver:
   
   <img width="972" alt="image" 
src="https://github.com/apache/spark/assets/6757692/b3372777-724d-4952-8755-f0db6fbe7329";>
   
   I think for driver, now the working directory is just placed before user 
jars, likes
   - --jars
   - localPrimaryResource
   
   It should be fine.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org