LuciferYang commented on PR #41487: URL: https://github.com/apache/spark/pull/41487#issuecomment-1579882516
> We can choose to add spark-connect-client-jvm.jar as Artifact to the server during testing, but this is relatively complex and spark-connect-client-jvm.jar does not always exist during Maven testing. So this PR chooses to move these two test cases to a separate file to pass Maven test. https://github.com/apache/spark/pull/41483/files has implemented the fix way of using `spark-connect-client-jvm.jar` and `spark-connect-client-jvm-tests.jar` as Artifacts, but this seems more complex and I prefer to use current one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
