LuciferYang commented on code in PR #41483:
URL: https://github.com/apache/spark/pull/41483#discussion_r1220027667
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -955,6 +955,7 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper with PrivateM
val session = spark
import session.implicits._
implicit val ec = ExecutionContext.global
+ assume(transferredClientTestJarIfNeed && transferredClientJarIfNeed)
Review Comment:
Because `ClientE2ETestSuite` has imported classes such as `SparkResult` in
client module, these two test cases need to also add
`spark-connect-client-jvm.jar` as an artifact.
So I think it would be better to move them from `ClientE2ETestSuite` to a
new test class like https://github.com/apache/spark/pull/41487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
