juliuszsompolski commented on code in PR #41440:
URL: https://github.com/apache/spark/pull/41440#discussion_r1222849401
##########
core/src/main/scala/org/apache/spark/status/api/v1/api.scala:
##########
@@ -199,6 +199,7 @@ class JobData private[spark](
val completionTime: Option[Date],
val stageIds: collection.Seq[Int],
val jobGroup: Option[String],
+ val jobTags: collection.Seq[String],
Review Comment:
@gengliangwang @rednaxelafx could you help what check could I make?
The change is a new optional (repeated) field in the proto. Any older
version of SHS reading that proto will ignore it. Any new version of SHS
reading proto from an older version will see it as an empty Seq (since empty
repeated == empty seq). So it should be backwards and forwards compatible. Are
there tests that I could add for that? I consulted
https://github.com/apache/spark/commit/fb67ce26800119a01633d5ffb05d8e341f76d3e6
which did a similar thing (add new fields to StageData and don't see extra
tests that I could add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
