zhengruifeng commented on code in PR #41515: URL: https://github.com/apache/spark/pull/41515#discussion_r1223794078
########## python/pyspark/sql/connect/functions.py: ########## @@ -1988,13 +1988,70 @@ def split(str: "ColumnOrName", pattern: str, limit: int = -1) -> Column: split.__doc__ = pysparkfuncs.split.__doc__ +def rlike(string: "ColumnOrName", pattern: Union[str, Column]) -> Column: Review Comment: for the python side, let's use `ColumnOrName` augments. that is, when `pattern` is a `str`, treat it as a column name see discussion here https://github.com/apache/spark/pull/41505#discussion_r1222631192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
