LuciferYang commented on code in PR #41546:
URL: https://github.com/apache/spark/pull/41546#discussion_r1226104583
##########
.github/workflows/build_and_test.yml:
##########
@@ -724,8 +725,9 @@ jobs:
export MAVEN_OPTS="-Xss64m -Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
export MAVEN_CLI_OPTS="--no-transfer-progress"
export JAVA_VERSION=${{ matrix.java }}
+ export SKIP_ENFORCER=$( [ "$JAVA_VERSION" = "8" ] && echo true || echo
false )
# It uses Maven's 'install' intentionally, see
https://github.com/apache/spark/pull/26414.
- ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes
-Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud
-Djava.version=${JAVA_VERSION/-ea} install
+ ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes
-Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud
-Djava.version=${JAVA_VERSION/-ea} -Denforcer.skip=${SKIP_ENFORCER} install
Review Comment:
No, what I mean is we should do this check when user submitting code,
especially for Java 8, otherwise the addition of this plugin will not have its
intended effect, so I think `enforcer.skip` should always be false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
