bowenliang123 commented on PR #41546: URL: https://github.com/apache/spark/pull/41546#issuecomment-1586639019
> So should we explicitly add a more appropriate `org.threeten:threeten-extra` dependency in this pr? There's no appropriate version of `threeten-extra` for solving the violation to this rule, as 1.7.1 (used by orc in spark-sql module now) and 1.7.2 (latest available release version) has the same problem. Also, `threeten` only requires Java 8 . `ThreeTen-Extra requires Java SE 8 or later and has no dependencies.` (quote from https://github.com/ThreeTen/threeten-extra) So the only workaround for this is adding an exclusion for `threeten-extra` in `enforceBytecodeVersion` rule. ``` <enforceBytecodeVersion> <maxJdkVersion>${java.version}</maxJdkVersion> <ignoredScopes>test</ignoredScopes> <excludes> <exclude>org.threeten:threeten-extra</exclude> </excludes> </enforceBytecodeVersion> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
