wangyum commented on code in PR #41332:
URL: https://github.com/apache/spark/pull/41332#discussion_r1228837517


##########
sql/core/src/test/scala/org/apache/spark/sql/UnwrapCastInComparisonEndToEndSuite.scala:
##########
@@ -264,5 +264,30 @@ class UnwrapCastInComparisonEndToEndSuite extends 
QueryTest with SharedSparkSess
     }
   }
 
+  test("SPARK-43801: Support unwrap date type to string type in 
UnwrapCastInBinaryComparison") {
+    val dt1 = "2023-01-01"
+    val dt2 = "2023-01-02"

Review Comment:
   Could you add another test?
   ```scala
   val dt3 = "2023-1-03"
   
   checkAnswer(df.where("dt = date'2023-01-03'"), Seq(dt3).map(Row(_)))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to