dongjoon-hyun commented on code in PR #41257:
URL: https://github.com/apache/spark/pull/41257#discussion_r1228920455
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -165,6 +165,16 @@ private[spark] object Config extends Logging {
.checkValue(_ <= 1048576, "Must have at most 1048576 bytes")
.createWithDefault(1048576) // 1.0 MiB
+ val SPARK_CONF_DIR_CONFIG_MAP_NAME =
+ ConfigBuilder("spark.kubernetes.sparkConfDir.configMapName")
Review Comment:
I was confused initially because this configuration requires a user-provided
config name.
Can we simply this new feature by simply controlled by a boolean
configuration instead of a random string name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
