advancedxy commented on code in PR #41257:
URL: https://github.com/apache/spark/pull/41257#discussion_r1228940101
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretVolumeUtils.scala:
##########
@@ -28,6 +28,14 @@ private[spark] object SecretVolumeUtils {
}
}
+ def podHasConfigMapVolume(pod: Pod, volumeName: String, configMapName:
String): Boolean = {
Review Comment:
Yes, I didn't find any similar methods, so this one is created. Do you have
any suggestions?
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/ClientSuite.scala:
##########
@@ -33,7 +33,7 @@ import org.scalatestplus.mockito.MockitoSugar._
import org.apache.spark.{SparkConf, SparkFunSuite}
import org.apache.spark.deploy.k8s.{Config, _}
-import org.apache.spark.deploy.k8s.Config.WAIT_FOR_APP_COMPLETION
+import org.apache.spark.deploy.k8s.Config._
Review Comment:
will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
