HyukjinKwon commented on code in PR #41580:
URL: https://github.com/apache/spark/pull/41580#discussion_r1230905039
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -788,6 +790,13 @@ class SparkConnectPlanner(val session: SparkSession)
extends Logging {
.logicalPlan
}
+ private def transformCachedRemoteRelation(session: SparkSession, rel:
proto.CachedRemoteRelation)
+ : LogicalPlan = {
+ SparkConnectService.cachedDataFrameManager
+ .get(session, rel.getRelationId)
+ .logicalPlan
Review Comment:
I think we should pass the session holder down here. I need this change too
later in https://github.com/apache/spark/pull/41495 as I need a session-based
behavior.
I am not too much concerned right now if that doesn't happen in this PR but
we will need such change soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
