jdesjean commented on code in PR #41443:
URL: https://github.com/apache/spark/pull/41443#discussion_r1231233615
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -63,6 +63,9 @@ class SparkConnectStreamHandler(responseObserver:
StreamObserver[ExecutePlanResp
}
val executeHolder = sessionHolder.createExecutePlanHolder(v)
+
+ sessionHolder.events.postStarted(executeHolder)
Review Comment:
Did Thriftserver expose pending / running events?
Will requests be put in a queue before being executed on the separate
thread? Do we expect the time between receiving the request and processing it
to be significant?
A few thoughts:
1) It would be preferable for both implementation to align as events with
the same name are meant to have the similar meaning.
2) Unless the request is queued, from a user perspective, it seems like the
request has started processing and the threading is an implementation detail.
3) We should measure time from end to end as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
