rangadi commented on code in PR #41540:
URL: https://github.com/apache/spark/pull/41540#discussion_r1231449566
##########
python/pyspark/sql/streaming/listener.py:
##########
@@ -155,11 +156,31 @@ class QueryStartedEvent:
This API is evolving.
"""
- def __init__(self, jevent: JavaObject) -> None:
- self._id: uuid.UUID = uuid.UUID(jevent.id().toString())
- self._runId: uuid.UUID = uuid.UUID(jevent.runId().toString())
- self._name: Optional[str] = jevent.name()
- self._timestamp: str = jevent.timestamp()
+ def __init__(
+ self, id: uuid.UUID, runId: uuid.UUID, name: Optional[str], timestamp:
str
+ ) -> None:
+ self._id: uuid.UUID = id
+ self._runId: uuid.UUID = runId
+ self._name: Optional[str] = name
+ self._timestamp: str = timestamp
+
+ @classmethod
+ def fromJObject(cls, jevent: JavaObject) -> "QueryStartedEvent":
+ return cls(
+ id=uuid.UUID(jevent.id().toString()),
+ runId=uuid.UUID(jevent.runId().toString()),
+ name=jevent.name(),
+ timestamp=jevent.timestamp(),
+ )
+
+ @classmethod
+ def fromJson(cls, j: Dict[str, Any]) -> "QueryStartedEvent":
Review Comment:
> I think we need to still let users to use import
pyspark.sql.streaming.Query<xxx>Event
@HyukjinKwon is this true? I think Users have only the Spark Connect python
code.
> import pyspark.sql.connect.streaming.Query<xxx>Event.
User code in a StreamingListener in connect is a Spark Connect code. I think
our imports statements import the right version (connect or legacy depending on
the environment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
