zhengruifeng commented on code in PR #41590:
URL: https://github.com/apache/spark/pull/41590#discussion_r1232962870
##########
connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala:
##########
@@ -27,7 +27,6 @@ import org.apache.kafka.clients.producer.ProducerConfig
import org.apache.kafka.clients.producer.internals.DefaultPartitioner
import org.apache.kafka.common.Cluster
import org.apache.kafka.common.serialization.ByteArraySerializer
-import org.scalatest.concurrent.TimeLimits.failAfter
import org.scalatest.time.SpanSugar._
Review Comment:
does it mean this `failAfter` was already used in this suite?
do we observe that the `failAfter` works in this suite?
##########
core/src/test/scala/org/apache/spark/SparkFunSuite.scala:
##########
@@ -147,7 +150,9 @@ abstract class SparkFunSuite
if (excluded.contains(testName)) {
ignore(s"$testName (excluded)")(testBody)
} else {
- super.test(testName, testTags: _*)(testBody)
+ super.test(testName, testTags: _*)(
+ failAfter(10.minutes)(testBody)
Review Comment:
I am not sure whether to add the `timeout` in general, or only used in the
slowest ones
also cc @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
