zhengruifeng commented on PR #41561: URL: https://github.com/apache/spark/pull/41561#issuecomment-1595740420
> Update all, exclude: 1.In Scala side: escapeChar: Char -> escapeChar: Column 2.In Python side: escapeChar: Optional["str"] -> Optional["ColumnOrName"] thanks for the update, my last suggestion would be ``` 1.In Scala side: escapeChar: Char -> escapeChar: Column 2.In Python side: escapeChar: Optional["str"] -> Optional["Column"]. ``` I still feel it would be ambiguous if treat str as the column name here; so I suggest to use `Optional["Column"]` and then support other types later (if we support a type now, it is nearly impossible to remove it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
