MaxGekk commented on code in PR #41553:
URL: https://github.com/apache/spark/pull/41553#discussion_r1233252365
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -633,6 +633,11 @@
],
"sqlState" : "23505"
},
+ "DUPLICATED_OBSERVED_METRICS_NAME" : {
+ "message" : [
+ "Multiple definitions of observed metrics named '<name>': <plan>."
Review Comment:
Could you borrow the message from the comment of `checkCollectedMetrics()`:
```suggestion
"The metric name is not unique: <metricName>. The same name cannot be
used for metrics with different results. However multiple instances of metrics
with with same result and name are allowed (e.g. self-joins)."
```
I think the metric name is enough, and the plan can be omitted.
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -633,6 +633,11 @@
],
"sqlState" : "23505"
},
+ "DUPLICATED_OBSERVED_METRICS_NAME" : {
Review Comment:
```suggestion
"DUPLICATED_METRICS_NAME" : {
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1967,6 +1984,11 @@
"The seed expression <seedExpr> of the expression <exprWithSeed> must be
foldable."
]
},
+ "SET_OPERATION_ON_MAP_TYPE_UNSUPPORTED" : {
Review Comment:
Technically, it can be supported, right? Could you add a sub-class to
`UNSUPPORTED_FEATURE`.
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1203,6 +1208,13 @@
}
}
},
+ "INVALID_NON_DETERMINISTIC_EXPRESSIONS" : {
+ "message" : [
+ "nondeterministic expressions are only allowed in Project, Filter,
Aggregate or Window, found:",
Review Comment:
You missed `Expand` and `LateralJoin`. BTW, could you make the message more
generic:
```suggestion
"The operator expects a deterministic expression, but the actual
expression is <expr>.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
