LuciferYang commented on PR #41622: URL: https://github.com/apache/spark/pull/41622#issuecomment-1596567749
@HyukjinKwon @dongjoon-hyun @pan3793 After more thought, I give a new one https://github.com/apache/spark/pull/41654 In https://github.com/apache/spark/pull/41654, I added a new apply function for NonFateSharingCache, the new apply function no longer use any Guava related types as input parameters, which can avoid the impact of using the shaded core module during Maven testing, and there is no need to move `NonFateSharingCache` from `core` to `catalyst` Does this approach look better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
