cloud-fan commented on code in PR #41568:
URL: https://github.com/apache/spark/pull/41568#discussion_r1233757442
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/parameters.scala:
##########
@@ -41,17 +36,56 @@ case class Parameter(name: String) extends LeafExpression
with Unevaluable {
override def nullable: Boolean = unboundError("nullable")
final override val nodePatterns: Seq[TreePattern] = Seq(PARAMETER)
+
+ def name: String
+}
+
+/**
+ * The expression represents a named parameter that should be replaced by a
literal.
+ *
+ * @param name The identifier of the parameter without the marker.
+ */
+case class NamedParameter(name: String) extends Parameter
+
+/**
+ * The expression represents a positional parameter that should be replaced by
a literal.
+ *
+ * @param pos An unique position of the parameter in a SQL query.
Review Comment:
```suggestion
* @param pos An unique position of the parameter in a SQL query text.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
