zhengruifeng commented on code in PR #41659:
URL: https://github.com/apache/spark/pull/41659#discussion_r1234564568
##########
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:
##########
@@ -1110,16 +1110,23 @@ class StringFunctionsSuite extends QueryTest with
SharedSparkSession {
}
test("endswith") {
- val df = Seq(("Spark SQL", "Spark")).toDF("a", "b")
+ val df = Seq(("Spark SQL", "Spark", Array[Byte](1, 2, 3, 4),
Array[Byte](3, 4)))
+ .toDF("a", "b", "c", "d")
+
+ checkAnswer(df.selectExpr("endswith(c, d)"), Row(true))
Review Comment:
yeah, I shouldn't change existing tests.
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
