dongjoon-hyun commented on code in PR #41374:
URL: https://github.com/apache/spark/pull/41374#discussion_r1235551102
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala:
##########
@@ -383,8 +383,7 @@ case class HashAggregateExec(
val isSupported =
(groupingKeySchema ++ bufferSchema).forall(f =>
CodeGenerator.isPrimitiveType(f.dataType) ||
f.dataType.isInstanceOf[DecimalType] ||
f.dataType.isInstanceOf[StringType] ||
- f.dataType.isInstanceOf[CalendarIntervalType]) &&
- bufferSchema.nonEmpty
Review Comment:
Got it.
> No
`bufferSchema.nonEmpty` was a legacy part of old commit in order to narrow
down the scope in other cases. I also think it's not used in that case.
> I don't quite understand bufferSchema.nonEmpty is for what? For example,
for query SELECT distinct a, b from tab ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
