viirya commented on code in PR #41374:
URL: https://github.com/apache/spark/pull/41374#discussion_r1235957028
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala:
##########
@@ -383,8 +383,7 @@ case class HashAggregateExec(
val isSupported =
(groupingKeySchema ++ bufferSchema).forall(f =>
CodeGenerator.isPrimitiveType(f.dataType) ||
f.dataType.isInstanceOf[DecimalType] ||
f.dataType.isInstanceOf[StringType] ||
- f.dataType.isInstanceOf[CalendarIntervalType]) &&
- bufferSchema.nonEmpty
Review Comment:
This condition was added in #12710. It was not explained clearly, but I
suppose that it is added because for performance improvement on it. I read
through related codes, seems this condition doesn't actually cause issue (I
might be missing it out actually). It is better if you can confirm there are
test coverage or you can add some.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
