mkaravel commented on PR #41486: URL: https://github.com/apache/spark/pull/41486#issuecomment-1599930759
> @dtenedor Thank you for this PR. Inline comments are mostly about naming and phrasing. > > My high level comment is that we have one more category of errors and this is related to passing BINARY values to `hll_union`, `hll_union_agg`, and `hll_sketch_estimate` that are not valid representations of sketches. At this point we rely on the DataSketches library to throw an exception for these cases, and we let that exception surface. My take on this is that we should add one more error class for these (along the lines of an illegal argument exception/error). What do you think? @dtenedor What about the above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
