dtenedor commented on code in PR #41486:
URL: https://github.com/apache/spark/pull/41486#discussion_r1240463194
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala:
##########
@@ -189,21 +189,20 @@ object HllSketchAgg {
private val minLgConfigK = 4
private val maxLgConfigK = 21
- // Replicate Datasketche's HllUtil's checkLgK implementation, as we can't
reference it directly
+ // Replicate Datasketches' HllUtil's checkLgK implementation, as we can't
reference it directly.
def checkLgK(lgConfigK: Int): Unit = {
if (lgConfigK < minLgConfigK || lgConfigK > maxLgConfigK) {
- throw new SketchesArgumentException(
- s"Log K must be between $minLgConfigK and $maxLgConfigK, inclusive: "
+ lgConfigK)
+ throw QueryExecutionErrors.hllInvalidLgK(function = "HLL_SKETCH_AGG",
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
