bersprockets commented on PR #41712: URL: https://github.com/apache/spark/pull/41712#issuecomment-1605228576
For the title, may I suggest: ``` [SPARK-44132][SQL] Materialize `Stream` of join column names to avoid codegen failure ``` For the description, may I suggest: ### What changes were proposed in this pull request? Materialize passed join columns as an `IndexedSeq` before passing it to the lower layers. ### Why are the changes needed? When nesting multiple full outer joins using column names which are a `Stream`, the code generator will generate faulty code resulting in a NPE or bad `UnsafeRow` access at runtime. See the 2 added test cases. etc.. (the rest is good) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
