panbingkun commented on PR #41572: URL: https://github.com/apache/spark/pull/41572#issuecomment-1605442340
> I have another concern, for testing backwards compatibility it might be useful to keep 'orphaned' protos around. This would effectively kill that. 1.Very good suggestion, but currently the orphan files deleted from the above, such as ``, `` These are all files submitted by mistake during the review process, 2.At the same time, I have added additional explanatory notes in the code comments. 3.We should provide an automated function to find orphaned files. As for whether to delete them, I think it needs to be weighed between the submitter and the code reviewer. Otherwise, many orphaned files are increasing, and many of them are only generated by submitting them incorrectly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
