mridulm commented on code in PR #41709:
URL: https://github.com/apache/spark/pull/41709#discussion_r1240849467
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -2287,6 +2287,22 @@ private[spark] object Utils extends Logging with
SparkClassUtils {
}.map(threadInfoToThreadStackTrace)
}
+ /** Return a heap dump. Used to capture dumps for the web UI */
+ def getHeapHistogram(): Array[String] = {
+ val pid = String.valueOf(ProcessHandle.current().pid())
+ val builder = new ProcessBuilder("jmap", "-histo:live", pid)
Review Comment:
@dongjoon-hyun This is an issue - we should use `$JAVA_HOME/bin/jmap` (more
specifically whatever comes from `System.getProperty("java.home")`), not the
first `jmap` which happens to be in the `PATH`. It is common to override
`JAVA_HOME` to specify the java version to be used explicitly (or even to not
have jdk in the PATH at all).
Also, there is no compatibility gaurantees that I am aware of between
different versions of jdk and jmap (for example, jdk11 jmap against jdk17 or
vice versa) - if I missed any, please do let me know !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
