Yikun opened a new pull request, #49: URL: https://github.com/apache/spark-docker/pull/49
### What changes were proposed in this pull request? Add 'set -eo pipefail' to entrypoint and quote variables ### Why are the changes needed? Address DOI comments: 1. Have you considered a set -eo pipefail on the entrypoint script to help prevent any errors from being silently ignored? 2. You probably want to quote this (and many of the other variables in this execution); ala --driver-url "$SPARK_DRIVER_URL" [1] https://github.com/docker-library/official-images/pull/13089#issuecomment-1601334895 [2] https://github.com/docker-library/official-images/pull/13089#issuecomment-1601813499 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
