panbingkun commented on PR #41169: URL: https://github.com/apache/spark/pull/41169#issuecomment-1606053243
> Hi @panbingkun , do you have time to address [#41169 (comment)](https://github.com/apache/spark/pull/41169#discussion_r1211911239) . If not I propose to revert it first and resubmit later. I don't think we have well-defined behavior for now: what if the `max_distance` parameter is null or negative? Should -1 mean no limitation so that we can unify the code? When max_distance = Int.MaxValue mean no limitation, I think it is possible to unify the code later on. The above design is because the `org.apache.commons.text.similarity.LevenshteinDistance` class also retains two methods: limitedCompare & unlimitedCompare. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
