panbingkun commented on code in PR #41718:
URL: https://github.com/apache/spark/pull/41718#discussion_r1241464167


##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -368,6 +368,24 @@ object functions {
    */
   def collect_set(columnName: String): Column = collect_set(Column(columnName))
 
+  /**

Review Comment:
   Returns a count-min sketch of a column with the given esp,
         confidence and seed. The result is an array of bytes, which can be 
deserialized to a
         `CountMinSketch` before usage. Count-min sketch is a probabilistic 
data structure used for
         cardinality estimation using sub-linear space.
   
   Is the comment above more aligned?
   
   
https://github.com/apache/spark/blob/00e7c08606d0b6de22604d2a7350ea0711355300/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala#L45-L48



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to