Hisoka-X commented on PR #41755:
URL: https://github.com/apache/spark/pull/41755#issuecomment-1609144566

   > hmm...If I remember correctly, @ulysses-you submitted a pr with similar 
goals
   
   Thanks @LuciferYang , I think you are talk about 
https://github.com/apache/spark/pull/41536/ . I think there are some different 
between two PR. @ulysses-you 's way will affect reuse exchange (I'm not sure 
this PR will or not, but according the CI, seem will not), this PR will force 
finish stage not cancel it. The behavior are different.
   
   By the way, please search `Unnecessary Stage` in 
https://github.com/Hisoka-X/spark/actions/runs/5387239085/jobs/9778311879 or 
https://github.com/Hisoka-X/spark/actions/runs/5387239085/jobs/9778311577 . 
Some query already benefited from this PR.
   
   Anyway, I'm not sure this way are best, only convert my thought to code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to