beliefer commented on code in PR #41757:
URL: https://github.com/apache/spark/pull/41757#discussion_r1243592898
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataTypeExpression.scala:
##########
@@ -65,3 +65,14 @@ object IntegralTypeExpression {
e.dataType.isInstanceOf[IntegralType]
}
}
+
+object DecimalExtractor {
Review Comment:
If the below `DecimalExpression` not used at all. Shall we rename this to
`DecimalExpression`?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala:
##########
@@ -141,13 +140,6 @@ object DecimalType extends AbstractDataType {
case DoubleType => DoubleDecimal
}
- private[sql] def fromLiteral(literal: Literal): DecimalType = literal.value
match {
Review Comment:
It seems no need to move this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
