zhengruifeng commented on code in PR #41718:
URL: https://github.com/apache/spark/pull/41718#discussion_r1243913397


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -4454,6 +4486,106 @@ object functions {
    */
   def right(str: Column, len: Column): Column = Column.fn("right", str, len)
 
+  /**
+   * Masks the given string value. The function replaces characters with 'X' 
or 'x', and numbers
+   * with 'n'. This can be useful for creating copies of tables with sensitive 
information
+   * removed.
+   *
+   * @param input
+   *   string value to mask. Supported types: STRING, VARCHAR, CHAR
+   * @group string_funcs
+   * @since 3.5.0
+   */
+  def mask(input: Column): Column = Column.fn("mask", input)
+
+  // scalastyle:off line.size.limit

Review Comment:
   +1, please remove them,
   
   I know there are some usage of `scalastyle:off line.size.limit` in this 
file, but they are due to long hyperlink string which can not be broken into 
multi line.
   
   In this PR, i think it is not needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to