zhenlineo commented on code in PR #40997:
URL: https://github.com/apache/spark/pull/40997#discussion_r1245534312
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2036,6 +2036,26 @@ class SparkConnectPlanner(val sessionHolder:
SessionHolder) extends Logging {
}
}
+ private def transformJoinWith(rel: proto.Join): LogicalPlan = {
+ val joined =
+
session.sessionState.executePlan(transformJoin(rel)).analyzed.asInstanceOf[logical.Join]
+
+ JoinWith.typedJoinWith(
+ joined,
+ session.sqlContext.conf.dataFrameSelfJoinAutoResolveAmbiguity,
+ session.sessionState.analyzer.resolver,
+ rel.getIsLeftRowStruct,
+ rel.getIsRightRowStruct)
+ }
+
+ private def transformJoinOrJoinWith(rel: proto.Join): LogicalPlan = {
+ if (rel.hasIsLeftRowStruct && rel.hasIsRightRowStruct) {
Review Comment:
But when running `typedJoinWith` we will need the boolean for left and right
individually. Do you mean a enum? This can be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
