ueshin commented on code in PR #41503:
URL: https://github.com/apache/spark/pull/41503#discussion_r1246085156
##########
python/pyspark/sql/pandas/serializers.py:
##########
@@ -190,7 +190,7 @@ def arrow_to_pandas(self, arrow_column,
struct_in_pandas="dict", ndarray_as_list
)
return converter(s)
- def _create_array(self, series, arrow_type, spark_type=None):
+ def _create_array(self, series, arrow_type, spark_type=None,
arrow_cast=False):
Review Comment:
On second thought, shall we revert the last commit
[9d359b9](https://github.com/apache/spark/pull/41503/commits/9d359b99d2dd53081da9aaa803c28634ed3ddab0)?
I feel weird that `arrow_to_pandas` takes parameters `struct_in_pandas` and
`ndarray_as_list` to control its behavior, whereas `_create_array` uses
`self._arrow_cast`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
